Bugs found for gen2 v3.230 re: TV show scraping

bugs found for tv_shows:

root folders doesn't work -- says no shows selected when you click on 'TV shows selector' or 'Search for new episodes'.
so you have to use list of separate folders which seems strange.

another bug is that the tv prefs seem to have been lost after saving them, so you need to re-select them and re-save them sometimes.

Also, I'm not seeing any episodes show up unless they are directly listed within the TV Show folder. If I have the following structure then it seems the MC is not creating the correct data to enable the episodes to be discovered once I switch to the XBOX/XBMC environment:
/root/TV Show/Series1/TVshow_s01e01 etc
It seems that having the episodes within separate series folders under each TV Show directory is possibly confusing MC -- unless I made some stupid mistake somewhere.
I did not change my directory structure, and it was working correctly when I used the XBOX/XBMC to scrape the TV shows/episodes using the 'Set content' menuitem, and selecting the TheTVDB.com as the scraper etc.

why are tv shows 'locked' after scrape completed?

also, getting srtange fanart.jpg -- nothing to do with the tv show being scraped. Don't recognise it. Seems to be from some period drama or other -- Jane Eyre? (one of my tv shows, coincidentally?). Seems to be in every folder!, at least many of the folders I checked.

after clicking tv show selector, after clicking 'scape show with selected options' i saw the following exception -- I had to quit application to get back control of the app -- the dialog window remained saying select scrape etc:

See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index
at System.ThrowHelper.ThrowArgumentOutOfRangeException(ExceptionArgument argument, ExceptionResource resource)
at System.ThrowHelper.ThrowArgumentOutOfRangeException()
at System.Collections.Generic.List`1.get_Item(Int32 index)
at Media_Companion.Form1.Button29_Click(Object sender, EventArgs e)
at System.Windows.Forms.Control.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ButtonBase.WndProc(Message& m)
at System.Windows.Forms.Button.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)


************** Loaded Assemblies **************
mscorlib
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.1433 (REDBITS.050727-1400)
CodeBase: file:///C:/WINDOWS/Microsoft.NET/Framework/v2.0.50727/mscorlib.dll
----------------------------------------
Media Companion
Assembly Version: 3.2.3.0
Win32 Version: 3.2.3.0
CodeBase: file:///C:/Documents%20and%20Settings/media/My%20Documents/Media%20Companion%20gen2%203.230/Media%20Companion.exe
----------------------------------------
Microsoft.VisualBasic
Assembly Version: 8.0.0.0
Win32 Version: 8.0.50727.1433 (REDBITS.050727-1400)
CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/Microsoft.VisualBasic/8.0.0.0__b03f5f7f11d50a3a/Microsoft.VisualBasic.dll
----------------------------------------
System
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.1433 (REDBITS.050727-1400)
CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System/2.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
System.Windows.Forms
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.1433 (REDBITS.050727-1400)
CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Windows.Forms/2.0.0.0__b77a5c561934e089/System.Windows.Forms.dll
----------------------------------------
System.Drawing
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.1433 (REDBITS.050727-1400)
CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Drawing/2.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll
----------------------------------------
System.Runtime.Remoting
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.1433 (REDBITS.050727-1400)
CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Runtime.Remoting/2.0.0.0__b77a5c561934e089/System.Runtime.Remoting.dll
----------------------------------------
System.Xml
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.1433 (REDBITS.050727-1400)
CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Xml/2.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
System.Configuration
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.1433 (REDBITS.050727-1400)
CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Configuration/2.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll
----------------------------------------
TVDB
Assembly Version: 1.0.0.0
Win32 Version: 1.0.0.0
CodeBase: file:///C:/Documents%20and%20Settings/media/My%20Documents/Media%20Companion%20gen2%203.230/TVDB.DLL
----------------------------------------
imdb
Assembly Version: 1.0.0.0
Win32 Version: 1.0.0.0
CodeBase: file:///C:/Documents%20and%20Settings/media/My%20Documents/Media%20Companion%20gen2%203.230/imdb.DLL
----------------------------------------
Accessibility
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.1433 (REDBITS.050727-1400)
CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/Accessibility/2.0.0.0__b03f5f7f11d50a3a/Accessibility.dll
----------------------------------------

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

<configuration>
<system.windows.forms jitDebugging="true" />
</configuration>

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.

When you select a root folder, the sub folders of that folder should be created in the List of Separate Folders. Is that happening for you?

Billy is aware of the TV prefs issue & I believe it will be fixed soon.

RE shows not showing in series folders......my understanding is that it shouldn't make any difference. In fact MC doesn't care about the name of the folder its the series read via the regex (e.g. S01) that determines the files series. What I have found however is that if my episodes are all in the root folder & then I create series folders & put the files in there I do have to rebuild the TV Shows since the path to those episodes have now changed.

Most of my TV shows are under series folders so this should also work for you. It may be related to the root folders issue.

Newly found TV shows are by default locked, not sure if this has been changed but logically they should be unlocked to start with since your next step usually is to add new episodes to that show. Hopefully Billy will let us know where we are up to with this part.

If a fanart is missing, sometimes the previously show fanart stays shown. Can you test to see if this is in fact what is happening? This may be fixed since I haven't noticed this in a while & with the new fanart filter I was able to add fanarts to all my shows.

I let Billy look at the exception too

Cheers

I assumed that it was sufficient to add just one root folder and that would be enough.
But from what you say, it sounds like after adding the root folder, you also need to click in the right-hand panel on the 'Add folders from roots' button. Is that right?

Regarding the episodes not being found, all I can say at the moment is that:
1. The episodes appeared fine in XBOX/XBMC when all episodes were directly contained withinh a TV Show folder.
2. If the episodes were located within TV Show/season/ directory then the episodes did not appear in XBOX/XBMC environment. I will repeat this again tomorrow to see if I did something stupid though. I presume MC recurses through all subdirectories in its processing to look for all files to scrape within each TV show/season subdirectory?

> If a fanart is missing, sometimes the previously show fanart stays shown. Can you test to see if this is in fact what is happening? This may be fixed since I haven't noticed this in a while & with the new fanart filter I was able to add fanarts to all my shows.

This does look like it's a bug still. Seems like the same kind of bug encountered when scraping movies, where if it failed to recognise the movie in IMDB, MC used faulty info to create an NFO using the stuff like 'The 82nd Annual Academy Awards (2010)'.

In cases where something is not fully recognised, it seems the correct course of action is to (1) report the problem somewhere (it can be seen in the logs IIRC), and (2) not generate garbage output from the scrape, either NFOs or icons etc.


Thanks, and I'll re-run all this again tomorrow...

Once the root folders have been added, you do need to add them to the show list, this can be achieved from the folders tab, or from the tv shows drop menu. It would probably be a good idea for me to have them added automatically.

As for adding garbage,
The imdb scraper at the moment always returns the academy awards ID, so MC scrapes the academy awards, this error has occured due to a change in the way IMDB has layed out its webpages, but even so, it generates a valid IMDB ID code, so MC scrapes it, it may be garbage to you, but not to MC.

I will be uploading a new build tomorrow where these issues will be dealt with.

When shows are scraped by MC they are added as locked (un-verified), this is to avoid a situation where MC scrapes the details for the wrong show and then scrapes lots of episodes for the wrong show. All it takes is a quick check and click the button to verify that the correct show has scraped.

I upgraded to 3.237 and added the sub folders, renamed my folders and TV show episodes correctly, did some rebuilding, searching for new episodes etc, until finally all is working nicely

There are still some exceptions thrown here and there, but I'm happy the NFOs, artwork etc is working.

Part of the problem is that it seems the performance of the TheTVDB.com site is often terrible, and MC says it can't grab something.

Would it be worth adding some kind of timeout option to allow MC to do a successful scrape, even if it needs to take a lot longer to pass through the list, due to slow thetvdb site performance, and MC having to wait longer before reporting scrape timeout failures?